<i>use [package vcompare] instead of dictionary sort for package versions</i>.
by
D 2015-04-13T02:54:10.092
J foundin trunk
J icomment teapot-client\suses\s[lsort\s-dictionary]\sto\sdetermine\sthe\snewest\spackage\r\nversion,\swhich\sis\sincorrect\s(case\sin\spoint:\stdbc).\r\n\r\nThe\sfollowing\spatch\sfixes\sthis\sAND\sinclides\sa\sworkaround\sfor\svectcl\r\nhttp://teapot.rkeene.org/entity/name/vectcl/index.html\swhich\sdoesn't\r\nconform\sto\s[package\svcompare].\s\sThe\slatter\sshould\ssurely\sbe\sfixed:\s\sActiveState's\steapot\sknows\sit\sonly\sas\s"0.1".\r\n\r\n\r\nIndex:\sclient/lib/teapotclient0.1/teapotclient.tcl\r\n==================================================================\r\n---\sclient/lib/teapotclient0.1/teapotclient.tcl\r\n+++\sclient/lib/teapotclient0.1/teapotclient.tcl\r\n@@\s-340,17\s+340,29\s@@\r\n\s\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\slappend\spkginfo($pkg)\s[list\s$ver\s$arch]\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n\s\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sforeach\spkg\s[array\snames\spkginfo]\s{\r\n-\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\spkginfo($pkg)\s[lsort\s-decreasing\s-dictionary\s$pkginfo($pkg)]\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\spkginfo($pkg)\s[lsort\s-decreasing\s-command\s::teapotclient::vcompare\s$pkginfo($pkg)]\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n\s\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sreturn\s[array\sget\spkginfo]\r\n\s\s\s\s\s\s\s\s}\r\n\s\r\n\s\s\s\s\s\s\s\sproc\ssetcachedir\s{dir}\s{\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\s::teapotclient::pkgcachedir\s$dir\r\n\s\s\s\s\s\s\s\s}\r\n+\r\n+\s\s\s\s\s\s\sproc\svcompare\s{a\sb}\s{\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\stry\s{\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\spackage\svcompare\s$a\s$b\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\son\serror\s{}\s{\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\stry\s{\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\spackage\svcompare\s[lindex\s$a\s0]\s[lindex\s$b\s0]\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\son\serror\s{}\s{\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sstring\scompare\s-nocase\s$a\s$b\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n+\s\s\s\s\s\s\s}\r\n\s}\r\n\s\r\n\spackage\sprovide\steapotclient\s0.1\r\n\r\nIndex:\sclient/teapot-client.tcl\r\n==================================================================\r\n---\sclient/teapot-client.tcl\r\n+++\sclient/teapot-client.tcl\r\n@@\s-88,15\s+88,15\s@@\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\sextinfoitemvers\s[lindex\s$extinfoitem\s0]\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sif\s{[lsearch\s-exact\s$extvers\s$extinfoitemvers]\s==\s-1}\s{\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\slappend\sextvers\s$extinfoitemvers\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n-\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\sextvers\s[lsort\s-decreasing\s-dictionary\s$extvers]\r\n+\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sset\sextvers\s[lsort\s-decreasing\s-command\s::teapotclient::vcompare\s$extvers]\r\n\s\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sputs\s"\s\s$ext\s[lindex\s$extvers\s0]"\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\s\sdefault\s{\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sprint_help\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sexit\s1\r\n\s\s\s\s\s\s\s\s}\r\n\s}
J login anonymous
J mimetype text/x-fossil-plain
J private_contact cb02a4a25e8da92f2790bc307bf01ef24ce6053e
J severity Severe
J status Open
J title use\s[package\svcompare]\sinstead\sof\sdictionary\ssort\sfor\spackage\sversions
J type Code_Defect
K 00bc6a8fb5e894a7480d154af8e14ea8d269560a
U anonymous
Z 55e143ae67f8423b412c22757f56b91e